Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 1046 #398

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Feature/ted 1046 #398

merged 4 commits into from
Dec 8, 2022

Conversation

CaptainOfHacks
Copy link
Collaborator

No description provided.

@swarmia
Copy link

swarmia bot commented Dec 7, 2022

✅  Linked to Bug TED-1046 · Remove new fields from fetch TED-API

@CaptainOfHacks CaptainOfHacks changed the base branch from release/1.0.0 to main December 7, 2022 14:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 98.82% // Head: 98.68% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (4907335) compared to base (31214c8).
Patch coverage: 68.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   98.82%   98.68%   -0.14%     
==========================================
  Files         125      125              
  Lines        6281     6297      +16     
==========================================
+ Hits         6207     6214       +7     
- Misses         74       83       +9     
Impacted Files Coverage Δ
ted_sws/core/model/transform.py 100.00% <ø> (ø)
...vices/create_batch_collection_materialised_view.py 100.00% <ø> (ø)
...ices/create_notice_collection_materialised_view.py 100.00% <ø> (ø)
ted_sws/notice_fetcher/adapters/ted_api.py 100.00% <ø> (ø)
...ter_data_registry/services/entity_deduplication.py 91.02% <68.96%> (-5.38%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CaptainOfHacks CaptainOfHacks merged commit 70c59f9 into main Dec 8, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-1046 branch December 8, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants