Feature/ted4 82 #515
Merged
Feature/ted4 82 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
+ Coverage 96.47% 96.53% +0.06%
==========================================
Files 112 113 +1
Lines 5978 6173 +195
==========================================
+ Hits 5767 5959 +192
- Misses 211 214 +3 ☔ View full report in Codecov by Sentry. |
ted_sws/core/model/metadata.py
Outdated
| @@ -81,6 +81,7 @@ class NormalisedMetadata(Metadata): | |||
| eforms_subtype: str | |||
| xsd_version: str | |||
| published_in_cellar_counter: int = Field(default=0) | |||
| is_eForm: Optional[bool] | |||
There was a problem hiding this comment.
- Keep snake style in code, rename is_eForm to is_eform.
- Provide default value as False.
There was a problem hiding this comment.
replaced name and added default value
| namespaces = dict([node for _, node in ET.iterparse(source=StringIO(xml_manifestation.object_data), | ||
| events=['start-ns'])]) | ||
|
|
||
| namespaces["manifestation_ns"] = namespaces.pop("") if "" in namespaces.keys() else "" |
There was a problem hiding this comment.
define and use constants instead of string literals
| tmp_dict = namespaces.copy() | ||
| items = tmp_dict.items() | ||
| for key, value in items: | ||
| if value.endswith("nuts"): |
There was a problem hiding this comment.
define and use constants instead of string literals
| @@ -55,6 +55,7 @@ def a_notice(normalised_notice): | |||
| @given('the notice is with form number F03') | |||
| def the_notice_is_with_form_number_f03(normalised_notice): | |||
| """the notice is with form number F03.""" | |||
| print(normalised_notice.normalised_metadata) | |||
There was a problem hiding this comment.
why we have print in tests?
There was a problem hiding this comment.
removed print statement
CaptainOfHacks
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.