Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates #531

Merged
merged 1 commit into from
Apr 4, 2024
Merged

updates #531

merged 1 commit into from
Apr 4, 2024

Conversation

kaleanych
Copy link
Contributor

No description provided.

@kaleanych kaleanych requested a review from Dragos0000 April 3, 2024 12:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (6a848b4) to head (c2d57a3).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   96.43%   96.81%   +0.38%     
==========================================
  Files         113      110       -3     
  Lines        6289     6099     -190     
==========================================
- Hits         6065     5905     -160     
+ Misses        224      194      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete notebooks.

@@ -1,104 +0,0 @@
{
"cells": [
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think is a good idea to delete this notebook

{
"cells": [
{
"cell_type": "code",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think is a good idea to delete this notebook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the notebooks were moved to mapping-toolchain project (in case of critical need, can be moved back)

@kaleanych kaleanych merged commit 02c3f7f into main Apr 4, 2024
3 checks passed
@kaleanych kaleanych deleted the feature/TED4-145 branch April 4, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants