added RML mapper in Airflow #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costezki
approved these changes
Apr 25, 2022
| @@ -12,6 +12,8 @@ COPY requirements.txt /opt/airflow | |||
|
|
|||
| # working in the /opt/airflow | |||
| WORKDIR /opt/airflow | |||
| RUN wget -c https://github.com/RMLio/rmlmapper-java/releases/download/v5.0.0/rmlmapper-5.0.0-r362-all.jar -P .rmlmapper/ | |||
| RUN mv .rmlmapper/rmlmapper-5.0.0-r362-all.jar .rmlmapper/rmlmapper.jar 2>/dev/null | |||
There was a problem hiding this comment.
not sure we shall crowd /opt/airflow with the RMLMapper
a cleaner alternative would be to place it into /opt/rmlmapper but this requires setting the right env variables
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 59 59
Lines 2385 2385
=======================================
Hits 2363 2363
Misses 22 22 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.