ability to compare version with x.y.z format #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 99.06% 99.07%
=======================================
Files 59 59
Lines 2362 2366 +4
=======================================
+ Hits 2340 2344 +4
Misses 22 22
Continue to review full report at Codecov.
|
costezki
approved these changes
Apr 25, 2022
| """ | ||
| version_numbers = [int(x) for x in version_string.split(".")] | ||
| assert len(version_numbers) == 3 | ||
| return ((version_numbers[0] * 100) + version_numbers[1]) * 100 + version_numbers[2] |
There was a problem hiding this comment.
:))))))))))))
That would work
There was a problem hiding this comment.
If you would go into [0,1] space you could easily handle 1,2,3,4... digit version numbers.
The same is valid for negative number space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.