-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ted 309 #88
Feature/ted 309 #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. It was not clear to me what was that original and modified files.
If you mean input and output, then name them so :)
|
||
def _write_resource_to_out_file(self, file_resource: FileResource, output_path: Path, idx: int = None): | ||
filename = file_resource.file_name | ||
original_name = file_resource.original_name if file_resource.original_name else filename |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is still not clear what is the original and what is the filename.
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 99.08% 99.09% +0.01%
==========================================
Files 59 59
Lines 2410 2441 +31
==========================================
+ Hits 2388 2419 +31
Misses 22 22
Continue to review full report at Codecov.
|
No description provided.