Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 309 #88

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Feature/ted 309 #88

merged 3 commits into from
Apr 27, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. It was not clear to me what was that original and modified files.
If you mean input and output, then name them so :)


def _write_resource_to_out_file(self, file_resource: FileResource, output_path: Path, idx: int = None):
filename = file_resource.file_name
original_name = file_resource.original_name if file_resource.original_name else filename
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is still not clear what is the original and what is the filename.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #88 (2fd98c4) into main (06a9947) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   99.08%   99.09%   +0.01%     
==========================================
  Files          59       59              
  Lines        2410     2441      +31     
==========================================
+ Hits         2388     2419      +31     
  Misses         22       22              
Impacted Files Coverage Δ
ted_sws/core/model/notice.py 98.75% <100.00%> (+0.01%) ⬆️
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
.../data_manager/adapters/mapping_suite_repository.py 99.39% <100.00%> (+0.07%) ⬆️
ted_sws/data_manager/adapters/notice_repository.py 98.18% <100.00%> (+0.14%) ⬆️
...ormer/entrypoints/cmd_mapping_suite_transformer.py 100.00% <100.00%> (ø)
.../notice_transformer/services/notice_transformer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d878de7...2fd98c4. Read the comment docs.

@kaleanych kaleanych merged commit e6e6688 into main Apr 27, 2022
@costezki costezki deleted the feature/TED-309 branch April 27, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants