Write of coverage data file in REE FS #231
Conversation
Make the function mk_path available to other components Signed-off-by: Franck LENORMAND <franck.lenormand@nxp.com>
The coverage data are data which are not encrypted and
should be available in clear for the user.
This patch adds an RPC allowing the TEE to write the
coverage data in REE FS in clear.
The configuration are:
- CFG_GCOV_SUPPORT: if the RPC is enabled, default to y
- CFG_TEE_CLIENT_COV_DIR: location where the data should be saved,
default to coverage subdir
Signed-off-by: Franck LENORMAND <franck.lenormand@nxp.com>
| #include <sys/types.h> | ||
| #include <sys/stat.h> | ||
| #include <unistd.h> | ||
| #include <fcntl.h> |
| @@ -0,0 +1,139 @@ | |||
| /* | |||
There was a problem hiding this comment.
Add an SPDX licence tag.
| #include <linux/tee.h> | ||
|
|
||
| #include "tee_supp_fs.h" | ||
| #include "coverage.h" |
There was a problem hiding this comment.
swap lines (alpha ordering)
|
|
||
| static const char *s_storage_dir = CFG_TEE_CLIENT_COV_DIR"/"; | ||
|
|
||
| static void fldump(const char* desc, const uint8_t *buf, uint32_t size) |
There was a problem hiding this comment.
i guess this will e removed :)
|
|
||
| TEEC_Result coverage_process(size_t num_params, struct tee_ioctl_param *params) | ||
| { | ||
| char *filepath; |
There was a problem hiding this comment.
Please add a default value at each local variable definition.
| EMSG("Cannot retrieve filepath\n"); | ||
| return TEEC_ERROR_BAD_PARAMETERS; | ||
| } | ||
| filepath_size = MEMREF_SIZE(params + 0); |
| cov_data_size = MEMREF_SIZE(params + 1); | ||
|
|
||
| /* Check the filepath is a string (null terminated) */ | ||
| if (filepath[filepath_size - 1] != '\0') { |
There was a problem hiding this comment.
don't search backward? (or forward)
There was a problem hiding this comment.
The size of the string is passed to the function and the last character is expected to be the final character so no need to search for it, just check it is present, else something went wrong.
| filepath); | ||
|
|
||
| /* Create the path of the file */ | ||
| n = snprintf(path, sizeof(path), "%s%s", s_storage_dir, filepath); |
There was a problem hiding this comment.
I would prefer to see / here rather than at s_storage_dir[] definition.
But not a strong opinion.
| return TEEC_ERROR_SHORT_BUFFER; | ||
| } | ||
|
|
||
| /* Create the path |
There was a problem hiding this comment.
Prefer
/*
* Create the path
* ...
*/| #include <teec_trace.h> | ||
|
|
||
| #if defined(CFG_GCOV_SUPPORT) | ||
|
|
There was a problem hiding this comment.
can remove these empty lines
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
Allow to write a coverage date file generated at runtime from optee core in plaintext in REE FS.
It stores the data files in a subfolder which can be configured by the user. The write of a data file has two arguments: