hikey960: Initial commit v2 #1684
Conversation
|
Comments addressed. |
| #define PL011_UART6_BASE 0xFFF32000 | ||
| #if defined(CFG_CONSOLE_UART) && (CFG_CONSOLE_UART == 5) | ||
| #define CONSOLE_UART_BASE PL011_UART5_BASE | ||
| #elif !defined(CFG_CONSOLE_UART) || (CFG_CONSOLE_UART == 6) |
There was a problem hiding this comment.
This can (and should) be #elif defined(CFG_CONSOLE_UART) && (CFG_CONSOLE_UART == 6) since CFG_CONSOLE_UART now has a default value set in conf.mk. The problem with the current code is that it will silently ignore any value different from 5 and 6 and use 6 in any case. Please fix line 41 (hikey-hikey) also.
There was a problem hiding this comment.
Good catch, thanks! In that case, can we simplify this to just #elif CFG_CONSOLE_UART == 6 and etc?
There was a problem hiding this comment.
The only thing with the simplification is that if CFG_CONSOLE_UART is not defined, then it will default to uart0 for hikey instead of printing an error.
There was a problem hiding this comment.
Yeah, !defined(CFG_CONSOLE_UART) is useless if we make sure it is always defined obviously.
|
Thanks @vchong, just one more comment, once it is addressed: Ah, yes, one more question, maybe for @etienne-lms. Since Hikey960 has both A53 and A73 cores, is it OK to have |
Signed-off-by: Victor Chong <victor.chong@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
|
Rebased, squashed and tags applied. Ready for merge. Thanks! @jforissier You're welcome! Please make sure you're ok with the |
Signed-off-by: Victor Chong <victor.chong@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
|
Sorry, please hold. One of the commit message needs to be changed. |
|
Commit message fixed. Thanks! |
The HiKey 960 development platform is based around the Huawei Kirin 960 octa-core ARM big.LITTLE processor with four ARM Cortex-A73 and four Cortex-A53 cores with 3GB of LPDDR4 SDRAM memory, 32GB of UFS 2.0 flash storage, and the latest generation Mali G71 MP8 graphics processor. See https://www.96boards.org/product/hikey960 for more details. Signed-off-by: Victor Chong <victor.chong@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Signed-off-by: Victor Chong <victor.chong@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
|
Thanks! |
Replaces #1681.
Please ignore first commit which is #1683.
Thanks!