-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUIDs in binary format have wrong endinanness #858
Labels
Comments
ghost
added
the
enhancement
label
Nov 3, 2016
jenswi-linaro
added a commit
to jenswi-linaro/optee_os
that referenced
this issue
Dec 8, 2016
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with normal world. Fixes: OP-TEE#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
added a commit
to jenswi-linaro/optee_client
that referenced
this issue
Dec 8, 2016
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with the kernel. Fixes: OP-TEE/optee_os#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
added a commit
to jenswi-linaro/optee_client
that referenced
this issue
Dec 9, 2016
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with the kernel. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE/optee_os#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
added a commit
to jenswi-linaro/optee_os
that referenced
this issue
Dec 9, 2016
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with normal world. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
takuya-sakata
pushed a commit
to renesas-rcar/optee_os
that referenced
this issue
Dec 22, 2017
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with normal world. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE/optee_os#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When encoding a UUID as a sequence of bytes, the spec says that the u32, and two u16s should be represented big endian. OPTEE always treats them natively, which on all supported targets is little-endian.
For most use cases, such as the
ioctl
interface, it doesn't really matter, as long as both ends misinterpret the bytes the same way. This is more of a concern if they are being stored or communicated in this format however.The text was updated successfully, but these errors were encountered: