Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non-secure DDR ranges to rcar-based boards #1871

Merged
merged 3 commits into from
Oct 12, 2017
Merged

Add non-secure DDR ranges to rcar-based boards #1871

merged 3 commits into from
Oct 12, 2017

Conversation

lorc
Copy link
Contributor

@lorc lorc commented Oct 10, 2017

There are two patches that configure nonsec DDR ranges for RCAR salvator-h3 and salvator-m3 boards.

@lorc lorc mentioned this pull request Oct 10, 2017
Merged
@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

@lorc
Copy link
Contributor Author

lorc commented Oct 11, 2017

Thank you, @jenswi-linaro. Looks like 32-bit build for this will depend on your #1860.
So, I'll wait your changes to be merged first.

@lorc lorc force-pushed the rcar-mem branch 2 times, most recently from d3ec5e2 to 5a54502 Compare October 12, 2017 11:17
@lorc
Copy link
Contributor Author

lorc commented Oct 12, 2017

I added new patch to force CFG_CORE_LARGE_PHYS_ADDR. It is the first in the series: "plat-rcar: force CFG_CORE_LARGE_PHYS_ADDR". @jenswi-linaro, can you please ack it?

Hmm, interesting. GitHub shows that this patch is the last. But I rebased it to be first, so next two patches will not break the build. Looks like GH sorts patches by commit time...

@jforissier
Copy link
Contributor

Looks like GH sorts patches by commit time...

Exactly, I find it disturbing, too. There is a justification for it: https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/...

@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

@lorc
plat-rcar: force CFG_CORE_LARGE_PHYS_ADDR
f6a55a3 
On RCAR3 platform most of the DRAM is mapped over 4GB, so it needs
LPE enabled with 32-bit builds.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
@lorc
plat-rcar: add initial support for salvator-m3 board
63f27ff 
Prior to this patch OP-TEE was able to run only at salvator-h3 board
(but it worked on salvator-m3 too, only by coincidence).

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
@lorc
plat-rcar: add non-secure DDR configuration
e00aeaf 
This patch adds non-secure DDR ranges for salvator-h3 and
salvator-m3 boards.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
@lorc
Copy link
Contributor Author

lorc commented Oct 12, 2017 •
edited
Loading

Thanks! Rebased and tags applied.

Exactly, I find it disturbing, too. There is a justification for it: https://help.github.com/articles/why-are-my-commits-in-the-wrong-order/...

So if you want to see real order, you need to clone PR locally? This is really disturbing...

@lorc
Copy link
Contributor Author

lorc commented Oct 12, 2017

After last rebase Shippable fails with strange error:

mkdir: cannot create directory 'out/arm-plat-vexpress': No such file or directory
mk/subdir.mk:151: recipe for target 'out/arm-plat-vexpress/core/ta_pub_key.c' failed

Have no idea how my patch can cause this. Maybe this is a broader issue?

@jforissier
Copy link
Contributor

This error I have never seen outside of Shippable... restarting the build usually works. I have restarted it.

@jforissier
Copy link
Contributor

Anyone can see the commits in the proper order at: https://github.com/OP-TEE/optee_os/commits/pull/1871/head.
More generally, [project_url]/commits/[git ref] can be used to see the history of a branch or at a particular commit. And pull/[id]/head is the tip of the branch for a PR, quite useful to check out a PR (git fetch origin pull/[id]/head && git checkout FETCH_HEAD).

@jforissier jforissier merged commit c5d84b7 into OP-TEE:master Oct 12, 2017
@lorc lorc deleted the rcar-mem branch October 12, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorc @jenswi-linaro @jforissier