Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpmb fix #1921

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Rpmb fix #1921

merged 1 commit into from
Nov 8, 2017

Conversation

jenswi-linaro
Copy link
Contributor

For all tests to pass #1919 is needed too, please ignore
"core: fix access conflict status in rpmb fs that panics TA" while reviewing this PR

@jenswi-linaro
Copy link
Contributor Author

Fixes #1780

@jforissier
Copy link
Contributor

For "core: RPMB_FS: remember owner uuid", with the proper 12-character SHA1 prefix in the commit description:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

@jenswi-linaro
Copy link
Contributor Author

FYI, "core: RPMB_FS: remember owner uuid" has a proper 12-character SHA1 prefix in the commit description, it's just github mangling the commit message.

@jforissier
Copy link
Contributor

Ah, yes indeed, but checkpatch expects "commit 078f18f ..." (the word "commit" has to be there).

@jenswi-linaro
Copy link
Contributor Author

Message updated, tag applied

@etienne-lms
Copy link
Contributor

#1919 is updated (tag applied)

@jforissier
Copy link
Contributor

@jenswi-linaro can you please rebase now that 1919 is merged? Thanks.

Prior to this patch was the owning uuid looked up via the current
session.  The assumption that the uuid of the context of the current
session is the same as the owner of a RPMB file doesn't hold any longer
after:
commit 078f18f ("core: RPMB FS: provide tee_rpmb_fs_raw_open()")
was introduced.

Instead the pointer to the uuid passed as the owner is stored in the
file handle and used as needed when encrypting/decrypting the file.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE#1780
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
@jenswi-linaro
Copy link
Contributor Author

Rebased

@jforissier jforissier merged commit b399f70 into OP-TEE:master Nov 8, 2017
@jenswi-linaro jenswi-linaro deleted the rpmb branch November 8, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants