plat-stm32: SCMI reset controllers on remoteproc are disabled on secure fmw loading #7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GseoC
reviewed
Nov 6, 2024
| if (rd->reset_id == MCU_HOLD_BOOT_R) | ||
| return SCMI_NOT_SUPPORTED; | ||
| /* Remoteproc driver may handle all MCU reset controllers */ | ||
| if (IS_ENABLED(CFG_STM32MP_REMOTEPROC) && rd->reset_id == MCU_R) |
There was a problem hiding this comment.
&& stm32_rproc_is_secure(xxx)
| #ifdef CFG_STM32MP15 | ||
| /* Remoteproc driver may handle all MCU reset controllers */ | ||
| if (IS_ENABLED(CFG_STM32MP_REMOTEPROC) & | ||
| (rd->reset_id == MCU_R || rd->reset_id == MCU_HOLD_BOOT_R)) |
|
@arnopo , do you want to give your tag as well? |
arnopo
approved these changes
Nov 6, 2024
|
@etienne-lms I'm just worried about |
|
Removal of |
Add stm32_remoteproc driver API function stm32_rproc_is_secure() that return whether of not remote processor management shall be handled through OP-TEE remoteproc secure services. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Forbid SCMI accesses to MCU reset controllers when remote processor is to be managed through OP-TEE remoteproc services. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Remove useless assertion on reset controller handle value. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
etienne-lms
force-pushed
the
stm32-rproc-reset
branch
from
8102e03
to
ee5d5f3
Compare
GseoC
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for STM32 remote proc driver and SCMI server to expose remoteproc reset controllers through SCMI only when the secure loading of remoteproc firmware is disabled. When so, remoteproc reset and power sequence shall go through OP-TEE remoteproc services, not SCMI platform services.