Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_truncate_file_length(): close and re-open object #249

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

jforissier
Copy link
Contributor

Update regression test 6007 to close and re-open the persistent object.
Reproducer for issue OP-TEE/optee_os#2094.

From: Kevin Peng kevinp@marvell.com
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

@etienne-lms
Copy link
Contributor

No comment on code.
Commit comment states "test_truncate_file_length()" but 2 sub-tests have modified.

Maybe you can also change test_file_hole(): create/read => create/read/close/read-again.
There is no issue over it, but in the same idea.

Whatever:
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>

@jforissier jforissier force-pushed the truncate-sync branch 2 times, most recently from 87a0a11 to ac53798 Compare February 1, 2018 14:00
@jforissier
Copy link
Contributor Author

Updated test_file_hole(), too.
I'll merge this when the fix is merged in optee_os.

Update regression test 6007 to close and re-open the persistent object
after truncation and extension.
Reproducer for issue OP-TEE/optee_os#2094.

Suggested-by: Kevin Peng <kevinp@marvell.com>
[jf: add close/open to test_file_hole(), too]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
@jforissier jforissier merged commit 3e7d107 into OP-TEE:master Feb 2, 2018
@jforissier jforissier deleted the truncate-sync branch February 2, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants