Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code signing step for preview pipeline #1122

Merged
merged 25 commits into from
Sep 21, 2020
Merged

Add code signing step for preview pipeline #1122

merged 25 commits into from
Sep 21, 2020

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Sep 21, 2020

Add code signing step if code signing certs and secret access is granted to the pipeline
note: until novotnyllc/NuGetKeyVaultSignTool#77 is fixed, using a private build of the NuGetKeyVaultSignTool

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1122 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   40.01%   40.00%   -0.01%     
==========================================
  Files         271      271              
  Lines      103796   103796              
==========================================
- Hits        41529    41522       -7     
- Misses      62267    62274       +7     
Impacted Files Coverage Δ
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs 62.85% <0.00%> (-1.64%) ⬇️
...ack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs 59.79% <0.00%> (-1.04%) ⬇️
Stack/Opc.Ua.Core/Stack/Tcp/TcpMessageSocket.cs 70.06% <0.00%> (-0.33%) ⬇️
Libraries/Opc.Ua.Client/Session.cs 22.97% <0.00%> (-0.16%) ⬇️
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 52.30% <0.00%> (+0.09%) ⬆️
...Security/Certificates/DirectoryCertificateStore.cs 85.09% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c37ac...9b487ea. Read the comment docs.

@mregen mregen deleted the signtool branch September 21, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants