Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vcpkg #12080

Merged
merged 5 commits into from
Jan 19, 2025
Merged

Bump vcpkg #12080

merged 5 commits into from
Jan 19, 2025

Conversation

magnesj
Copy link
Member

@magnesj magnesj commented Jan 19, 2025

A msys package was removed from the upstream distribution server, causing a new build on a blank system to fail. The issue is not seen if the binary is cached locally by vcpkg. To fix this, a newer vcpkg.exe was required. When this was done, several other issues appeared.

Baseline for vcpkg is now set to 2025.01.11

  • Use fmt 10.1.1 to avoid compile bug on MSVC
  • Avoid pinning of Protobuf
  • Remove obsolete Protobuf at top level

References

apache/arrow#42027
microsoft/vcpkg#42965
https://github.com/microsoft/vcpkg-tool/releases/tag/2025-01-11

A blank install of vcpkg did not work anymore due to changes in upstream repos. Had to update vcpkg.exe to latest to ensure download of libraries works as expected.

Had to update baseline to 2024.02.14 to be able to compile on VS 17.12. A bug related to naming of boost was fixed in boost 1.84

microsoft/vcpkg#38980
@magnesj magnesj marked this pull request as ready for review January 19, 2025 15:15
@magnesj magnesj merged commit d17ecc4 into dev Jan 19, 2025
16 checks passed
@magnesj magnesj deleted the bump-vcpkg branch January 19, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant