Add workaround for libc++ incomplete from_chars(). #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
akva2
approved these changes
Aug 12, 2024
bska
reviewed
Aug 12, 2024
opm/models/utils/parametersystem.hh
Outdated
Comment on lines
934
to
936
| // Floating point workaround. | ||
| char* end_ptr = nullptr; | ||
| defaultValue = std::strtod(defVal.c_str(), &end_ptr); |
There was a problem hiding this comment.
Tiny simplification: It's okay to call strtod() as
defaultValue = std::strtod(defVal.c_str(), nullptr);in this case.
Float version not included in current version (15).
atgeirr
force-pushed
the
from_char-workaround
branch
from
89503c1 to
2ad332e
Compare
|
jenkins build this please |
bska
approved these changes
Aug 12, 2024
bska
added a commit
to bska/opm-models
that referenced
this pull request
Aug 15, 2024
This commit broadens the scope of commit 2ad332e (PR OPM#922) to apply to all compilers/libraries, not just Clang/libc++. While hopefully a transient situation, this enables building the parameter system with GCC versions prior to GCC 11. We expect to require version 11 in the not too distant future, though. At that point we should revert this commit.
bska
added a commit
to bska/opm-models
that referenced
this pull request
Aug 15, 2024
This commit broadens the scope of commit 2ad332e (PR OPM#922) to apply to all compilers/libraries, not just Clang/libc++, which do not have support for floating-point types in std::from_chars(). While hopefully a transient situation, this enables building the parameter system with GCC versions prior to GCC 11. We expect to require version 11 in the not too distant future, though. At that point we should revert this commit. We use a configure-time feature test of the compiler (CMake command 'try_compile') to detect whether or not the compiler supports floating-point overloads of std::from_chars() and emit the result to config.h as the new preprocessor symbol HAVE_FLOATING_POINT_FROM_CHARS We use std::strtod() as the fall-back alternative for floating point conversion if this symbol is defined to false (zero).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float version not included in current version of libc++(15).