Welcome email ready to go #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il information along with the email and orcid id
| @@ -2,7 +2,7 @@ | |||
| # NotificaionManager.java | |||
|
|
|||
| email.subject.verify_reminder=[ORCID] Verify your email address | |||
| email.subject.verify_reminder_primary=[ORCID] Reminder to verify your primary email address | |||
| email.subject.verify_reminder_primary=[ORCID] Don't forget to verify your email address | |||
There was a problem hiding this comment.
Please note that since email.subject.verify_reminder_primary has been modified, other languages will retain the translations for the previous string until we complete a translation cycle.
This is why I generally recommend not modifying existing keys. Instead, I prefer to delete old keys and create new ones.
This might not be a significant issue right now since the changes are minor.
leomendoza123
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.