Naming convention, adding data from website, and CsI test #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data/Kaye-NobleMetals.dat
Outdated
There was a problem hiding this comment.
Should rename it similar to other files and use elements instead of NobleMetals
data/Kaye-ternaryMiscibility.dat
Outdated
data/Liang-AlMg.dat
Outdated
There was a problem hiding this comment.
How about AlMg-Liang.dat? If we do this for all the files we should get the data files sorted by elements and the author names will still be acknowledged.
data/Pham-CsI.dat
Outdated
data/Dupin-ZrH.dat
Outdated
data/Kang-CuFeC.dat
Outdated
data/Kaye-MoPdRuRhTc.dat
Outdated
There was a problem hiding this comment.
MoPdRuRhTc-Kaye.dat
README.md
Outdated
| Once the Ubuntu app is successfully installed, you can follow the [Building Thermochimica](#building-thermochimica) instructions below. | ||
| When Ubuntu app is successfully installed, run the following. | ||
| ```bash | ||
| sudo apt-get update |
There was a problem hiding this comment.
Suggested change
| sudo apt-get update | |
| sudo apt update && sudo apt upgrade |
parikshitbajpai
requested changes
May 5, 2024
| @@ -12,15 +12,15 @@ | |||
| phaseIncludeTol = 1e-8 | |||
|
|
|||
| class CalculationWindow: | |||
| def __init__(self, parent, datafile, nElements, elements, active): | |||
| def __init__(self, parent, datafile, nElements, elements, active,scrollable=True): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, parent, datafile, nElements, elements, active,scrollable=True): | |
| def __init__(self, parent, datafile, nElements, elements, active, scrollable=True): |
| self.parent = parent | ||
| self.datafile = datafile | ||
| self.nElements = nElements | ||
| self.elements = elements | ||
| self.active = active | ||
| if self.active: | ||
| self.makeLayout() | ||
| self.sgw = sg.Window(f'Phase Diagram Setup: {os.path.basename(self.datafile)}', self.layout, location = [400,0], finalize=True) | ||
| self.sgw = sg.Window(f'Phase Diagram Setup: {os.path.basename(self.datafile)}', self.layout,resizable=True,size=(600, 800),location = [400,0], finalize=True) |
There was a problem hiding this comment.
Suggested change
| self.sgw = sg.Window(f'Phase Diagram Setup: {os.path.basename(self.datafile)}', self.layout,resizable=True,size=(600, 800),location = [400,0], finalize=True) | |
| self.sgw = sg.Window(f'Phase Diagram Setup: {os.path.basename(self.datafile)}', self.layout, resizable=True, size=(600,800), location = [400,0], finalize=True) |
| @@ -254,8 +254,8 @@ def makeLayout(self): | |||
| if (self.nElements < 8): | |||
| elemLayout = [sg.Column(elem1Layout),sg.Column(elem2Layout)] | |||
| else: | |||
| elemLayout = [sg.Column(elem1Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, expand_y = True), | |||
| sg.Column(elem2Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, expand_y = True)] | |||
| elemLayout = [sg.Column(elem1Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200, 100),expand_y = True), | |||
There was a problem hiding this comment.
Suggested change
| elemLayout = [sg.Column(elem1Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200, 100),expand_y = True), | |
| elemLayout = [sg.Column(elem1Layout, vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200,100), expand_y = True), |
| elemLayout = [sg.Column(elem1Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, expand_y = True), | ||
| sg.Column(elem2Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, expand_y = True)] | ||
| elemLayout = [sg.Column(elem1Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200, 100),expand_y = True), | ||
| sg.Column(elem2Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200, 100), expand_y = True)] |
There was a problem hiding this comment.
Suggested change
| sg.Column(elem2Layout,vertical_alignment='t', scrollable = True, vertical_scroll_only = True, size=(200, 100), expand_y = True)] | |
| sg.Column(elem2Layout, vertical_alignment='t', scrollable = True, vertical_scroll_only=True, size=(200,100), expand_y=True)] |
|
Sorry for the late response. I will get on it and make sure your suggestions will be used. I updated the file names to system-owner.dat. And all files are from the tutorial, excluding one that we cannot post there should be no need to worry on that end. |
parikshitbajpai
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.