Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mpiexec to run unit tests #37

Merged
merged 16 commits into from
Aug 6, 2024
Merged

Use mpiexec to run unit tests #37

merged 16 commits into from
Aug 6, 2024

Conversation

quantumsteve
Copy link
Collaborator

No description provided.

@quantumsteve
Copy link
Collaborator Author

test this please

@quantumsteve
Copy link
Collaborator Author

Test this please

@quantumsteve
Copy link
Collaborator Author

Test this please

3 similar comments
@idigs
Copy link
Member

idigs commented Jun 10, 2024

Test this please

@idigs
Copy link
Member

idigs commented Jun 10, 2024

Test this please

@idigs
Copy link
Member

idigs commented Jun 10, 2024

Test this please

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@quantumsteve
Copy link
Collaborator Author

Test this please

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@quantumsteve
Copy link
Collaborator Author

@cianciosa mars_test passes on one process but is failing failing on two or more processes. Are there random number initialization differrences?

@mbeidler3
Copy link
Collaborator

@quantumsteve I've been trying to create gold data for multiple processor runs. However, when running on my machine, each processor has rank=0 and nmpi=1. Also, it's even more confusing because only one processor prints the output.korc file even though that task is done by rank=0. I compiled the recent version on Perlmutter using their module system (cray-mpich for MPI, rather than openmpi on my system) and it initialized the MPI processes as expected.

@mbeidler3
Copy link
Collaborator

@quantumsteve, I'm getting the same result for a build with mpich. On my machine, I see it compiling with gfortran and including the MPI library directoy, while on Perlmutter I see it compiling with the wrapper compiler ftn. Could the issue be that my system is not compiling with the correct MPI-wrapped compilers?

@quantumsteve
Copy link
Collaborator Author

@quantumsteve, I'm getting the same result for a build with mpich. On my machine, I see it compiling with gfortran and including the MPI library directoy, while on Perlmutter I see it compiling with the wrapper compiler ftn. Could the issue be that my system is not compiling with the correct MPI-wrapped compilers?

Something is going on with the wrapper. If I add export FC=mpifort to build.sh, I get one output file per process. Not setting FC and I only get a single file for ranks 1, 2, and 4. With rank 8, I get 8 files in both cases 😕

Signed-off-by: Steven Hahn <hahnse@ornl.gov>
@quantumsteve
Copy link
Collaborator Author

Test this please

@idigs idigs self-requested a review August 5, 2024 20:43
Copy link
Member

@idigs idigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes

@mbeidler3 mbeidler3 merged commit 7ed0514 into main Aug 6, 2024
2 checks passed
@mbeidler3 mbeidler3 deleted the ctest_use_mpiexec branch August 6, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants