Add tracer annotations to HIP code in ReSolve #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
requested review from
kswirydo,
cameronrutherford,
PaulMullowney and
nkoukpaizan
kswirydo
approved these changes
Jan 23, 2024
nkoukpaizan
reviewed
Jan 23, 2024
| # The assumption is roctracer lib and headers are installed at the same | ||
| # place as the rest of ROCm. | ||
| target_link_libraries(ReSolve PUBLIC "-lroctracer64 -lroctx64") | ||
| elseif(RESOLVE_USE_CUDA) |
There was a problem hiding this comment.
I'd suggest throwing a warning or error here to notify the user that profiling is currently only support with roctx.
There was a problem hiding this comment.
I believe 918a794 addresses this comment.
cameronrutherford
approved these changes
Jan 23, 2024
| # The assumption is roctracer lib and headers are installed at the same | ||
| # place as the rest of ROCm. | ||
| target_link_libraries(ReSolve PUBLIC "-lroctracer64 -lroctx64") | ||
| elseif(RESOLVE_USE_CUDA) |
Comment on lines
+153
to
+154
| message(NOTICE "Profiling support enabled, but Re::Solve does not create tracer annotations for host code.") | ||
| message(NOTICE "This profiling support option will have no effect.") |
There was a problem hiding this comment.
Could support this with a different profiling tool like caliper/tau... At the same time, I don't see why we couldn't use ROCm/CUDA profilers to view host code performance as well, albeit that would require a hack + messy CMake
There was a problem hiding this comment.
You are right, we can, it is just that I didn't do it in this PR. Probably the message should say "tracer annotation not implemented for ...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some generic support for building ReSolve with profiling annotations and implement ROC Tracer annotations for HIP-based code in ReSolve. This is based on
no-splitlu-exp-roctxbranch by @PaulMullowney.This will allow us to add in a straightforward manner annotations for CUDA (and other) profilers in the future.
Note that ROC Tracer does not provide CMake targets (see roctracer issue 56), so the CMake configuration for it looks like a hack.
Closes #68.