Attempting to fix broken rsync #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfsilva I noticed that you changed the run methods arguments of the Plugins class, I have also adapted the check() method of the Plugins class so that it is identical to the run method (meaning it takes the same arguments). |
|
@rafaelfsilva please merge this if you are happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rafaelfsilva I noticed that you had commented out the rsync tests in main. They are broken in main after you refactored a few things. I just wanted to make sure you knew how to test them if you need to. I'll try to fix them in this pr. The tests are set to run between two of the vms on CADES Cloud that Ketan set up. One of them has an env variable defined that points to the SSH key you need to run the tests. The last 2 digits of the IP for that machine are 48.