Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First step to integrating queue client with processor #45

Merged
merged 6 commits into from
Oct 13, 2022
Merged

First step to integrating queue client with processor #45

merged 6 commits into from
Oct 13, 2022

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Sep 30, 2022 •
edited
Loading

This pr replaces the direct calls to the nats queue with an abstract queue_client layer in the processor.py file.

@JoshuaSBrown JoshuaSBrown marked this pull request as draft September 30, 2022 03:31
@JoshuaSBrown JoshuaSBrown requested a review from tskluzac October 6, 2022 12:52
@JoshuaSBrown JoshuaSBrown marked this pull request as ready for review October 6, 2022 12:53
@JoshuaSBrown JoshuaSBrown requested a review from wilkinson October 6, 2022 12:55
@JoshuaSBrown
Copy link
Collaborator Author

Would like feedback before this is merged in.

@JoshuaSBrown JoshuaSBrown merged commit 8d48dc9 into main Oct 13, 2022
@JoshuaSBrown JoshuaSBrown deleted the JoshuaSBrown-integrate-queue-with-processor branch October 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskluzac tskluzac Awaiting requested review from tskluzac

@wilkinson wilkinson Awaiting requested review from wilkinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshuaSBrown