Integration test using docker compose #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devel to main so we can proceed with agent rewrite.
- Removing /zambeze volume - Keeping ../db:/zambeze/db volume - Running with subprocess.Popen
JoshuaSBrown
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
If it works, I'm happy to get this in as soon as possible, thanks for cleaning it up. I have a few minor suggestions. I would also like to know more about the details of the problem so I don't reproduce it. Thanks again this was a lot of work and much appreciated.
tests/test_imagemagick_files.py
Outdated
Comment on lines
39
to
40
| print(stdout) | ||
| print(stderr) |
There was a problem hiding this comment.
Maybe just clean this file of the extraneous print statements.
Comment on lines
-25
to
-27
| tty: true | ||
| stdin_open: true | ||
| volumes: |
There was a problem hiding this comment.
So this was the culprit, I don't know how you figured this out.
JoshuaSBrown
added
the
DevOps: CI
|
Please close the other PR that is opened against main when you have merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagemagick-files.pyfrom agent2 communicating with agent1, using the current compose file.Tests passing: https://github.com/ORNL/zambeze/actions/runs/3888182470