Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing notebook test timeout in all GH actions #81

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Increasing notebook test timeout in all GH actions #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b2ae7
Increasing notebook test timeout in all GH actions
renan-souza Sep 20, 2023
82ea1d2
Test tensorboard waits
renan-souza Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/create-release-n-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/test-python-310.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
2 changes: 1 addition & 1 deletion .github/workflows/test-python-39.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
run: |
python flowcept/flowcept_webserver/app.py &
sleep 3
pytest --nbmake "notebooks/" --ignore=notebooks/dask_from_CLI.ipynb
pytest --nbmake "notebooks/" --nbmake-timeout=600 --ignore=notebooks/dask_from_CLI.ipynb
5 changes: 3 additions & 2 deletions tests/plugins/test_tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ def test_observer_and_consumption(self):
self._init_consumption()
wf_id = self.test_run_tensorboard_hparam_tuning()
self.logger.debug("Done training. Sleeping some time...")
TestTensorboard.consumer.stop()
watch_interval_sec = self.interceptor.settings.watch_interval_sec
# Making sure we'll wait until next watch cycle
sleep(watch_interval_sec * 7)
sleep(watch_interval_sec * 5)
TestTensorboard.consumer.stop()
sleep(watch_interval_sec * 5)
assert self.interceptor.state_manager.count() == 16
doc_dao = DocumentDBDao()
docs = doc_dao.query({"workflow_id": wf_id})
Expand Down