Skip to content

Commit

Permalink
Merge pull request #2545 from rouault/fix_gdal_test_issue_due_to_intl…
Browse files Browse the repository at this point in the history
…_rename

isEquivalentName(): fix for GDAL test failure
  • Loading branch information
rouault authored Feb 22, 2021
2 parents 4dcce2a + 6ef286e commit 1a51877
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/iso19111/metadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1124,7 +1124,7 @@ void Identifier::_exportToJSON(JSONFormatter *formatter) const {
//! @cond Doxygen_Suppress
static bool isIgnoredChar(char ch) {
return ch == ' ' || ch == '_' || ch == '-' || ch == '/' || ch == '(' ||
ch == ')' || ch == '.' || ch == '&';
ch == ')' || ch == '.' || ch == '&' || ch == ',';
}
//! @endcond

Expand Down
4 changes: 4 additions & 0 deletions test/unit/test_metadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -391,4 +391,8 @@ TEST(metadata, Identifier_isEquivalentName) {
EXPECT_TRUE(Identifier::isEquivalentName("a", "\xc3\xa1"));

EXPECT_TRUE(Identifier::isEquivalentName("\xc3\xa4", "\xc3\xa1"));

EXPECT_TRUE(Identifier::isEquivalentName(
"Unknown based on International 1924 (Hayford 1909, 1910) ellipsoid",
"Unknown_based_on_International_1924_Hayford_1909_1910_ellipsoid"));
}

0 comments on commit 1a51877

Please sign in to comment.