Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjJson 0.2 Schema Incorrect for Prime Meridian? #2354

Closed
mlptownsend opened this issue Sep 16, 2020 · 4 comments
Closed

ProjJson 0.2 Schema Incorrect for Prime Meridian? #2354

mlptownsend opened this issue Sep 16, 2020 · 4 comments
Labels
Milestone

Comments

@mlptownsend
Copy link
Contributor

Problem description

Love the projjson schema and output, but I may have found a problem with the prime_meridian definition. If you output EPSG:22300 and EPSG:31293, you'll see the difference.

EPSG:22300:

"prime_meridian": {
"name": "Paris",
"longitude": {
  "value": 2.5969213,
  "unit": {
	"type": "AngularUnit",
	"name": "grad",
	"conversion_factor": 0.0157079632679489
  }
}
}

EPSG:31293:

"prime_meridian": {
"name": "Ferro",
"longitude": -17.6666666666667
}

The 0.2 schema defines the prime_meridian as seen in 22300 with longitude as value and unit, but it doesn't seem to account for the version seen in 31293 which has longitude as a number only.

Or maybe it's a problem with how projinfo is spitting out EPSG:31293 as projjson?

Environment Information

PROJ 7, Windows 10 x64.

Installation method

Built from source.

Full outputs of "projinfo -o projjson EPSG:22300 -q" and "projinfo -o projjson EPSG:31293 -q" attached.
22300.txt
31293.txt

rouault added a commit that referenced this issue Sep 16, 2020
… can just be a number, in which case the unit is implicitly degrees (fixes #2354)
@rouault rouault added this to the 7.2.0 milestone Sep 16, 2020
@rouault
Copy link
Member

rouault commented Sep 16, 2020

Was indeed a bug of the schema

@kbevers
Copy link
Member

kbevers commented Sep 17, 2020

@rouault should the schema version be bumped to 0.2.1 after this fix?

@rouault
Copy link
Member

rouault commented Sep 17, 2020

should the schema version be bumped to 0.2.1 after this fix?

I considered that a bit, but here it is a bug of the schema. I believe that issuing a new schema version should be done only if PROJ emits something different from before. But perhaps I can change the "description": "Schema for PROJJSON" to "description": "Schema for PROJJSON (v0.2.1)" inside the schema ?

@kbevers
Copy link
Member

kbevers commented Sep 17, 2020

But perhaps I can change the "description": "Schema for PROJJSON" to "description": "Schema for PROJJSON (v0.2.1)" inside the schema ?

Yes, I think that's a good compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants