Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Unit Tests With 8.2 Branch #2931

Closed
mlptownsend opened this issue Nov 8, 2021 · 0 comments
Closed

Failing Unit Tests With 8.2 Branch #2931

mlptownsend opened this issue Nov 8, 2021 · 0 comments
Assignees
Labels

Comments

@mlptownsend
Copy link
Contributor

I was trying out the 8.2 branch and hit a snag with some crash outs on some of the unit tests, but with seemingly the same error.

These will do it:
proj_clone_of_obj_with_alternative_operations
proj_concatoperation_get_step
proj_get_celestial_body_name

Example stack trace:

>	proj_8_2_d.dll!std::_List_const_iterator<std::_List_val<std::_List_simple_types<osgeo::proj::io::Step>>>::operator++() Line 165	C++
 	proj_8_2_d.dll!std::_List_iterator<std::_List_val<std::_List_simple_types<osgeo::proj::io::Step>>>::operator++() Line 252	C++
 	proj_8_2_d.dll!osgeo::proj::io::PROJStringFormatter::toString::__l60::<lambda>() Line 7683	C++
 	proj_8_2_d.dll!osgeo::proj::io::PROJStringFormatter::toString() Line 8132	C++
 	proj_8_2_d.dll!osgeo::proj::io::IPROJStringExportable::exportToPROJString(osgeo::proj::io::PROJStringFormatter * formatter) Line 7378	C++
 	proj_8_2_d.dll!osgeo::proj::operation::FilterResults::sort() Line 1219	C++
 	proj_8_2_d.dll!osgeo::proj::operation::FilterResults::andSort() Line 972	C++
 	proj_8_2_d.dll!osgeo::proj::operation::filterAndSort(const std::vector<dropbox::oxygen::nn<std::shared_ptr<osgeo::proj::operation::CoordinateOperation>>,std::allocator<dropbox::oxygen::nn<std::shared_ptr<osgeo::proj::operation::CoordinateOperation>>>> & sourceList, const dropbox::oxygen::nn<std::unique_ptr<osgeo::proj::operation::CoordinateOperationContext,std::default_delete<osgeo::proj::operation::CoordinateOperationContext>>> & context, const std::shared_ptr<osgeo::proj::metadata::Extent> & extent1, const std::shared_ptr<osgeo::proj::metadata::Extent> & extent2) Line 1432	C++
 	proj_8_2_d.dll!osgeo::proj::operation::CoordinateOperationFactory::createOperations(const dropbox::oxygen::nn<std::shared_ptr<osgeo::proj::crs::CRS>> & sourceCRS, const dropbox::oxygen::nn<std::shared_ptr<osgeo::proj::crs::CRS>> & targetCRS, const dropbox::oxygen::nn<std::unique_ptr<osgeo::proj::operation::CoordinateOperationContext,std::default_delete<osgeo::proj::operation::CoordinateOperationContext>>> & context) Line 5517	C++
 	proj_8_2_d.dll!proj_create_operations(pj_ctx * ctx, const PJconsts * source_crs, const PJconsts * target_crs, const PJ_OPERATION_FACTORY_CONTEXT * operationContext) Line 8148	C++
 	proj_test_cpp_api.exe!`anonymous namespace'::CApi_proj_concatoperation_get_step_Test::TestBody() Line 4300	C++

image

Happening due to this:
image
image

Environment Information

  • PROJ 8.2 [fa8a542]
  • Operation System: Windows 11 Pro x64

Installation method

  • From source
@mlptownsend mlptownsend added the bug label Nov 8, 2021
@rouault rouault self-assigned this Nov 8, 2021
rouault added a commit to rouault/PROJ that referenced this issue Nov 8, 2021
rouault added a commit to rouault/PROJ that referenced this issue Nov 8, 2021
rouault added a commit to rouault/PROJ that referenced this issue Nov 9, 2021
@rouault rouault closed this as completed in 3300531 Nov 9, 2021
rouault added a commit that referenced this issue Nov 9, 2021
PROJStringFormatter::toString(): avoid invalid iterator increment (fixes #2931)
github-actions bot pushed a commit that referenced this issue Nov 9, 2021
PROJStringFormatter::toString(): avoid invalid iterator increment (fixes #2931)
rouault added a commit that referenced this issue Nov 9, 2021
[Backport 8.2] PROJStringFormatter::toString(): avoid invalid iterator increment (fixes #2931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants