-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to allow export of Geographic/Projected 3D CRS in WKT1_GDAL #2450
Add option to allow export of Geographic/Projected 3D CRS in WKT1_GDAL #2450
Conversation
e09d675
to
aaa583a
Compare
as CompoundCRS with a VerticalCRS being an ellipsoidal height, which is not conformant. But needed for LAS 1.4 that only supports WKT1
aaa583a
to
4caf32a
Compare
Thanks @rouault . How does it behave with projected CRSs not in meters? In the US it is common to use |
it will indicate whatever unit is used for the vertical axis |
This PR is about the export to WKT1, not how this vertical axis was generated. Sorry for the misunderstanding. |
@rouault This fix worked well, can we target it for 7.2.1 vs 8.0? |
Nope. New features does not go into bug fix releases. |
I would counter that this isn't really a new feature, its a restoration of previous (if not quite conformant) behavior. We have a fair amount of that was written this way |
For what is worth, I'd be OK to backport that in 7.2.1. The new code paths don't change existing behavior (you need to specify the new option), so there's no backward incompatibility |
A new options is added to |
This is a function that PDAL uses and its preventing conversion of LAS 1.4 pointclouds due to the way that WKT is stored in LAS1.4. So it does have an impact. |
I could possibly make the new C++ methods internal only and remove the new projinfo option in the 7.2 backport. PDAL through GDAL will only needs the new option value in the "char**" options of proj_as_wkt() |
Sounds like a good solution to me |
Good solution, thanks @rouault |
as CompoundCRS with a VerticalCRS being an ellipsoidal height, which is not conformant. But needed for LAS 1.4 that only supports WKT1 This is a partial backport of OSGeo#2450, with only the new ALLOW_ELLIPSOIDAL_HEIGHT_AS_VERTICAL_CRS=YES option of proj_as_wkt()
as CompoundCRS with a VerticalCRS being an ellipsoidal height, which is
not conformant. But needed for LAS 1.4 that only supports WKT1