-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error management: revise error codes and expose them to the public API #2487
Conversation
Fixes OSGeo#2482 And also add proj_context_errno_string() Revise gie 'expect failure errno XXXX' strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot go through here. For this initial review I've only added a few comments in the start. Some of them will be relevant throughout the PR since they are a bit fundamental to how errors and loggin should be handled.
God job so far. It's a big project to change all of this to the better!
…OMAIN when it returns invalid coordinate
cc0ec69
to
4f1002a
Compare
…ix in the error message
…ges now that it is automatically added
bd7bc5c
to
41c4e54
Compare
@kbevers Do you wish to review more things in this PR ? |
No, I think this looks good as it is! |
Fixes #2482
Three classes of errors are defined:
And also add proj_context_errno_string()
Revise gie 'expect failure errno XXXX' strings
Other related changes: