Enable linking against static cURL on Windows #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
added a commit
to Cadcorp/PROJ
that referenced
this pull request
Feb 5, 2021
…RL 7.75.0 We are going to fix this for the upstream OSGeo#2514
This is preliminary fix to allow linking the library as well as its dependants (e.g. PROJ apps) against cURL built as static library on Windows with support of native Windows TLS/SSL. On Windows, such static cURL (and its dependants) requires linking against Winsock, CryptoAPI and other networking libaries.
|
@kbevers Thanks for reminder. I've just updated the PR resolving the conflict. |
mloskot
changed the title
... and it took me like five minutes to create another conflict :-) At least I know how to fix this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preliminary fix to allow linking the library
as well as its dependants (e.g. PROJ apps) against cURL
built as static library on Windows with support of native
Windows TLS/SSL.
On Windows, such static cURL (and its dependants) requires linking
against Winsock, CryptoAPI and other networking libaries.
This patch is a minimal version confirm to work with cURL 7.75.0 built as SChannel mode (old name WinSSL, see curl/curl#3504), that is MSVC outputs binaries into:
References