Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Solaris 11.4 #2620

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Fix build on Solaris 11.4 #2620

merged 1 commit into from
Mar 28, 2021

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 28, 2021

No description provided.

@hobu
Copy link
Contributor

hobu commented Mar 28, 2021

This fix seems not worth it. It makes the code more confusing, and do we really need to care about ancient Solaris?

@rouault
Copy link
Member Author

rouault commented Mar 28, 2021

Actually, it matches more the signature of the manpage of dladdr() on Linux too:

       #define _GNU_SOURCE
       #include <dlfcn.h>

       int dladdr(void *addr, Dl_info *info);

@rouault
Copy link
Member Author

rouault commented Mar 28, 2021

But interestingly, on Linux:

$ grep dladdr /usr/include/dlfcn.h 
extern int dladdr (const void *__address, Dl_info *__info)

So it thinks that Linux has 'hardened' things, but POSIX has a looser definition.

@rouault rouault merged commit 292943e into OSGeo:master Mar 28, 2021
github-actions bot pushed a commit that referenced this pull request Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants