Update internal nlohmann/json to 3.9.1, and add a CMake option to be able to use external nlohmann/json #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review in progress, and may take a few days ... my spare time is limited. I'll probably add a commit here when ready, as I'm seeing potential conflicts from Ubuntu bionic with nlohmann-json-dev, which is too old (2.1.1) and doesn't contain NLOHMANN_JSON_VERSION_* definitions. |
|
See some suggested edits at rouault#7 |
…g allowing to choose which nlohmann/json to use Co-authored-by: Mike Taves <mwtoews@gmail.com>
rouault
force-pushed
the
nlohmann_json_update
branch
from
b495917 to
29ac85d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using external nlohmann/json can potentially help reducing binary size for people doing static builds with other components that already use it. And more in line with the general philosophy of packaging.