Docs: Add new Ellipsoids page to explain ellipsoidal parameters. #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing the spaces indentation and small typo.
Pull in commits by @RohitPingale, originally submitted under PR OSGeo#2385. That PR was closed due to inactivity. My intention is to pick up the work where they left off.
Incorporate suggested changes from @kbevers on the original PR OSGeo#2385.
The author the original figure did not provide a source for the image. The image also had "geoid" misspelled in its labels, and label placement was somewhat confusing. This new image was created from scratch to match the design intent of the original image, but reuses none of its assets directly. I include the SVG source. This image is licensed CC0.
Per suggestion from @kbevers in PR OSGeo#2385
Add an item to News for the change.
kbevers
reviewed
Nov 5, 2021
|
Thanks for taking this up again. In terms of the commit history this PR is a bit messy, so I'll just squash merge it when the time comes. That will make the two of you co-authors of that single commit, which I guess reflect the state of things quite well. |
mwtoews
reviewed
Nov 5, 2021
|
Thanks for the additional markup improvements! Good pickup on the "semi" axis labels too, I feel a bit silly for not noticing that. Guess I was too focussed on the diagram design and not thinking critically about its contents. I think splitting those axes in half and tuning down the opacity on the unlabelled half will do the trick. I'll make that change on the branch. |
Divide the axis lines into two parts and fade out the unlabelled part, to indicate that "semi-" refers to one half of the axis only.
direvus
force-pushed
the
1064-docs-ellipsoid
branch
from
8d0ec2f to
3fba3df
Compare
|
Thanks @mwtoews, I think I've got those final changes covered now. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2021
Co-authored-by: Rohit <rohitpingale103@gmail.com> Co-authored-by: Brendan Jurd <brendan.jurd@geoplex.com.au> Co-authored-by: Mike Taves <mwtoews@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #2385, which appears to have been abandoned by its original author.
I haved merged the commits from that PR, incorporated the PR feedback, and made a few changes and improvements of my own.
I hope you find this helpful.