Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belgian geoid model hBG18 to grid alternatives #3044

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

AlexBass05
Copy link
Contributor

Corresponding PR in PROJ-data: OSGeo/PROJ-data#77

Created as a draft PR as it requires an EPSG database update to include this change request: https://epsg.org/closed-change-request/browse/id/2022.007

@rouault rouault marked this pull request as ready for review February 13, 2022 10:41
@rouault rouault added this to the 9.0.0 milestone Feb 13, 2022
@rouault
Copy link
Member

rouault commented Feb 13, 2022

I've rebased your PR on top of #3051 which updates to EPSG v10.054

Things seem to work fine:

$ echo "50 5 0" | PROJ_NETWORK=ON PROJ_DEBUG=2 PROJ_LIB=data bin/cs2cs EPSG:4937 EPSG:9907
[...]
Using https://cdn.proj.org/be_ign_hBG18.tif
50.00	5.00 -44.32

@kbevers
Copy link
Member

kbevers commented Feb 14, 2022

@rouault is this (and the corresponding PROJ-data PR) ready to merge? I'm gearing up for the release candidate and want to merge as much as possible. If possible I'd like to do the RC tomorrow afternoon (DK time).

@rouault rouault merged commit 944efc5 into OSGeo:master Feb 14, 2022
@rouault
Copy link
Member

rouault commented Feb 14, 2022

merged

@AlexBass05
Copy link
Contributor Author

I've rebased your PR on top of #3051 which updates to EPSG v10.054

Things seem to work fine:

$ echo "50 5 0" | PROJ_NETWORK=ON PROJ_DEBUG=2 PROJ_LIB=data bin/cs2cs EPSG:4937 EPSG:9907
[...]
Using https://cdn.proj.org/be_ign_hBG18.tif
50.00	5.00 -44.32

Excellent! Thanks a lot for the rebase and the merge.
Testing on my side also indicates that things work fine.

@AlexBass05 AlexBass05 deleted the add-belgian-geoid-hbg18 branch April 2, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants