Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: fix installation of proj.pc on Windows (fixes #3078) #3099

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 8, 2022

No description provided.

@rouault
Copy link
Member Author

rouault commented Mar 8, 2022

hum, from the log of a build before the change (https://github.com/OSGeo/PROJ/runs/5470513722?check_suite_focus=true), proj.pc was correctly installed in D:/a/PROJ/PROJ/proj_dir/lib/pkgconfig/proj.pc

@shawnlaffan could you confirm if this pull request improves things for you

But I notice there's another issue on Windows with man pages being installed in /man1/ ( although man/CMakeLists.txt has DESTINATION share/man/man1)

@shawnlaffan
Copy link

Thanks @rouault

This fixes the pkgconfig issue I reported in #3078

@shawnlaffan
Copy link

And FWIW, the man1 dir for my builds is at .../share/man/man1, not at the system root level.

@dg0yt
Copy link
Contributor

dg0yt commented Mar 9, 2022

I would prefer if GNUInstallDirs would be used consistently. It is the only common denominator for configuring packages in the CMake world. (It also facilitates contributions.)

@rouault
Copy link
Member Author

rouault commented Mar 9, 2022

I would prefer if GNUInstallDirs would be used consistently.

agreed, but too substantial to attack for a bug fix. I've filed that as #3100

@rouault rouault merged commit 15f1e40 into OSGeo:master Mar 9, 2022
github-actions bot pushed a commit that referenced this pull request Mar 9, 2022
CMake: fix installation of proj.pc on Windows (fixes #3078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants