Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Vertical Offset and slope transformation method #3200

Merged
merged 3 commits into from
May 16, 2022

Conversation

rouault
Copy link
Member

@rouault rouault commented May 14, 2022

@kbevers I was not sure how to map the latitude and longitude of the "evaluation point" of the method, which is the 'origin' of the inclinated plane, to PROJ string parameters. I've used the classic lon_0 and lat_0 parameters, but not completely sure it is appropriate (I have to re-add lon_0 in the forward method, since generic code in PROJ, substracts it, as it is what is convenient for map projections)

@rouault rouault added this to the 9.1.0 milestone May 14, 2022
Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure how to map the latitude and longitude of the "evaluation point" of the method, which is the 'origin' of the inclinated plane, to PROJ string parameters. I've used the classic lon_0 and lat_0 parameters, but not completely sure it is appropriate (I have to re-add lon_0 in the forward method, since generic code in PROJ, substracts it, as it is what is convenient for map projections)

I think the use of +lat_0 and +lon_0 fits the bill here. The meaning is of course a little bit different but I think it works alright in this case.

src/transformations/vertoffset.cpp Show resolved Hide resolved
@rhuijben
Copy link
Contributor

Can you update the in c declaration header to include the required arguments of the projection, like we have in the other projection definitions?

In my Proj use I try to automatically create some test scenario's based on those. And it would also be nice for the built-in help from the Proj tools.

@rouault
Copy link
Member Author

rouault commented May 15, 2022

Can you update the in c declaration header to include the required arguments

done, although as I mentioned in a commit comment, we haven't done that for transformation operations until now, just map projections

@rouault rouault merged commit d9ccb4b into OSGeo:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants