pj_get_suggested_operation(): tune for GDA94 <--> WGS84 and GDA2020 <…-> WGS84 #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…--> WGS84 Before this change, the au_icsm_GDA94_GDA2020_conformal_and_distortion.tif was considered as the best operation for GDA94 <--> WGS84 and GDA2020 <--> WGS84. This change makes the null transformation be the prefered one instead. Applying the GDA94 <--> GDA2020 grid was highly questionable GDA2020 <--> WGS84. Not completely sure for GDA94 <--> WGS84 though... Relates to qgis/QGIS#51792
|
I'll weigh in next week -- this is too tricky for a Sunday morning 🤣 |
|
Yep, this looks correct by my understanding: gda2020 <-> gda94 -- not null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the au_icsm_GDA94_GDA2020_conformal_and_distortion.tif was considered as the best operation for GDA94 <--> WGS84 and GDA2020 <--> WGS84 from cs2cs / proj_crs_to_crs() point of view. This change makes the null transformation be the prefered one instead. Applying the GDA94 <--> GDA2020 grid was highly questionable GDA2020 <--> WGS84. Not completely sure for GDA94 <--> WGS84 though...
Relates to qgis/QGIS#51792
@nyalldawson Opinion greatly welcome