Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proj-docs Docker image to Ubuntu 24.04 #4128

Merged
merged 3 commits into from
Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
container: ["proj","proj-docs"]
container: ["proj","proj-docs-2404"]
dockerfile: ["./Dockerfile", "./docs/docbuild/Dockerfile"]
exclude:
- container: "proj"
dockerfile: "./docs/docbuild/Dockerfile"
- container: "proj-docs"
- container: "proj-docs-2404"
dockerfile: "./Dockerfile"
env:
PUSH_PACKAGES: ${{ github.repository_owner == 'OSGeo' && github.event_name != 'pull_request' }}
Expand Down
3 changes: 2 additions & 1 deletion Doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -2010,7 +2010,8 @@ PREDEFINED = DOXYGEN_ENABLED \
PROJ_OPAQUE_PRIVATE_DATA= \
PROJ_PRIVATE=private \
PROJ_PURE_DECL= \
noexceptoverride="noexcept override"
noexceptoverride="noexcept override" \
PROJ_NO_RETURN=

# If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this
# tag can be used to specify a list of macro names that should be expanded. The
Expand Down
24 changes: 8 additions & 16 deletions docs/docbuild/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,32 +1,24 @@
FROM ubuntu:22.04
FROM ubuntu:24.04

RUN apt-get -y update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python3-dev python3-pip g++ doxygen dvipng latexmk \
cmake libjpeg8-dev zlib1g-dev texlive-latex-base \
texlive-latex-extra git latex-cjk-all texlive-lang-all \
graphviz python3-matplotlib wget unzip enchant-2 locales

RUN python3 -m pip install "Sphinx<7" breathe \
RUN DEBIAN_FRONTEND=noninteractive apt-get install -y python3-venv
ENV VIRTUAL_ENV=/opt/venv
RUN python3 -m venv $VIRTUAL_ENV
ENV PATH="$VIRTUAL_ENV/bin:$PATH"

RUN python3 -m pip install Sphinx breathe \
sphinx_bootstrap_theme sphinxcontrib-bibtex \
sphinx_rtd_theme recommonmark sphinx-markdown-tables \
"sphinxcontrib-spelling!=7.4.0,<8"
sphinxcontrib-spelling setuptools

# Set the locale for spelling
RUN sed -i -e 's/# en_GB.UTF-8 UTF-8/en_GB.UTF-8 UTF-8/' /etc/locale.gen && \
dpkg-reconfigure --frontend=noninteractive locales && \
update-locale LANG=en_GB.UTF-8

ENV LANG en_GB.UTF-8

RUN DEBIAN_FRONTEND=noninteractive apt-get install -y curl flex bison && \
curl -LOs https://doxygen.nl/files/doxygen-1.9.5.src.tar.gz && \
tar xvzf doxygen-1.9.5.src.tar.gz && \
rm -rf doxygen-1.9.5.src.tar.gz && \
cd doxygen-1.9.5 && \
mkdir build && \
cd build && \
cmake .. -DCMAKE_INSTALL_PREFIX=/usr && \
make -j$(nproc) && \
make install && \
cd ../.. && \
rm -rf doxygen-1.9.5
9 changes: 9 additions & 0 deletions src/iso19111/io.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,7 @@ void WKTParser::Private::emitRecoverableWarning(const std::string &errorMsg) {
warningList_.push_back(errorMsg);
}
}
//! @endcond

// ---------------------------------------------------------------------------

Expand All @@ -1552,6 +1553,7 @@ void WKTParser::Private::emitGrammarError(const std::string &errorMsg) {
grammarErrorList_.push_back(errorMsg);
}
}
//! @endcond

// ---------------------------------------------------------------------------

Expand Down Expand Up @@ -1597,6 +1599,7 @@ static ParsingException buildRethrow(const char *funcName,

// ---------------------------------------------------------------------------

//! @cond Doxygen_Suppress
std::string WKTParser::Private::stripQuotes(const WKTNodeNNPtr &node) {