Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISEA Inverse projection (#3047) #4211

Merged
merged 4 commits into from
Aug 14, 2024
Merged

ISEA Inverse projection (#3047) #4211

merged 4 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. ISEA Inverse projection (OSGeo#3047)

    - Integrating code ported from Java to eC, then eC to C++ implementing the inverse ISEA projection
    - Originally from Franz-Benjamin Mocnik's ISEA implementation found at
       https://github.com/mocnik-science/geogrid/blob/master/src/main/java/org/giscience/utils/geogrid/projections/ISEAProjection.java
       (MIT License)
    - NOTE: The inverse only supports the default planar options
    jerstlouis committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    825682a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. ISEA: Optimizations, unification and simplification

    - Eliminating several redundant trigonometric function calls
    - Single shared definition of dodecahedron vertices
      (centers of icosahedral triangular faces) for
      forward and inverse
    - Shared data structure for forward and inverse
    - Consistent use of 0-base index for triangular faces
    jerstlouis committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5f0aedf View commit details
    Browse the repository at this point in the history
  2. ISEA: Removing extraneous multiplications, unused code

    - NOTE: There may have been an undocumented +rescale= parameter which
    will no longer work
    jerstlouis committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7874a3a View commit details
    Browse the repository at this point in the history
  3. ISEA: Save four trigonometric calls

    - Avoid calling isea_rotate() in isea_tri_plane() to rotate
      coordinates in bottom triangles by 180 degrees.
    jerstlouis committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d1d8a5a View commit details
    Browse the repository at this point in the history