-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub actions: compile driver on Ubuntu #1
Conversation
All compiles and the tests are executed. Still:
For this, the upcoming release of GRASS 7.8.8 (relevant change: OSGeo/grass#2280) is needed |
With current released GRASS versions, you need to add the location of GRASS libraries to |
.github/workflows/test_simple.sh
Outdated
rm -f nc_spm_08_micro.zip ) | ||
|
||
# workaround for GRASS GIS < 7.8.8 | ||
export LD_LIBRARY_PATH=$(pkg-config --libs-only-L grass | sed 's+-L++g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this ($(pkg-config --libs-only-L grass | sed 's+-L++g')
) is resolved as LD_LIBRARY_PATH=/usr/lib/grass7.8/lib
shouldn't it be LD_LIBRARY_PATH=/usr/lib/grass78/lib
(without dot)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is certain it is G78 then
LD_LIBRARY_PATH=$(grass78 --config path)
could be an alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, I overlooked the dot!
Watch outcome here:
https://github.com/neteler/gdal-grass/actions/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, a generic way to set LD_LIBRARY_PATH
that works with both GRASS 7 and GRASS 8 should be used if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, a generic way to set
LD_LIBRARY_PATH
that works with both GRASS 7 and GRASS 8 should be used if possible.
Absolutely. As grass.pc
seem to be broken an alternative is: grass --config path
which seems to work. But pre-G8 it is grass78 --config path
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success! And yes, changed now to "versionless" with grass
as well.
https://github.com/neteler/gdal-grass/actions/runs/2260092078
Thanks for your assistance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success! And yes, changed now to "versionless" with
grass
as well.https://github.com/neteler/gdal-grass/actions/runs/2260092078
Thanks for your assistance!
Great! Is grass78
symlinked to grass
on Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an explainer if it wasn't obvious. LD_LIBRARY_PATH
needs to be set for being picked up by ctypesgen, for loading the libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Is
grass78
symlinked tograss
on Linux?
At least on Debian, Ubuntu and Fedora yes.
First attempt to compile GDAL-GRASS driver including tests for GRASS GIS raster and vector maps.