[Backport release/3.4] OGR: Backport fixes for Is3D & IsMeasured from #5477 to 3.4
#5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that there won't be any 3.4.x official releases anymore at that point |
|
actually if the change that went in 3.5.0 breaks users (I wouldn't have expected it, but that's something that can happen for a feature release), it is not appropriate for backport in a stable branch like 3.4, so I believe this PR shouldn't be merged. |
|
Well, it was a workaround for a bug, the documented behavior didn't change. But this PR doesn't make sense if there's no more 3.4.x releases, so I've closed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backports fixes for
Is3D&IsMeasuredfrom #5477 to 3.4What are related issues/pull requests?
The GeoParquet support introduced in #5477, also fixed two smaller bugs in
Is3DandIsMeasured, namely that they don't return a boolean as documented, but the result of a bitflag and operation.This change was breaking for packages that worked around this bug, when 3.5 was introduced in downstream packages, such as GDAL.jl 1.4 in yeesian/ArchGDAL.jl#307.
By backporting, we can align the behaviour of downstream supported versions.
Tasklist