-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t.rast.import.netcdf: handle empty CRS and no subdataset #1188
Conversation
I just tested with the same command reported in #1182 and I get:
and I need to Ctrl-C to stop it. I am not sure this is an issue of t.rast.import.netcdf or r.in.gdal. If I add the |
Sorry, @veroandreo The CHIRPS dataset was a bit tricky. The upside is that it exposed a few other bugs in corner cases... Now I added a test for CHIRPS as well and extended the testsuite. That particular dataset may still cause trouble in praxis as the server seems very slow. It could be an advantage to download and import (or link) from there. That said, users must take care if reprojection is required on import (no -o flag). In that case the computational region has to be defined reasonably and the r-flag should probably be set (esp. when importing global data into projected CRS).... Added a few sentence on that in the manual... |
Tests are failing due to version conflict in |
There might be hope, but we shouldn't count on this SciTools/cf-units#438 (comment) |
Tests pass locally. Is it OK to merge now and wait for cf_units to be updated? Then the improved / working module would become available. Tests should pass as soon as cf_units is NumPy 2 compatible... Will check that. We use the module in praxis and actually need the fix... |
Taking the liberty to merge with tests failing due to version conflict in CI setup. Having the module working is needed. Tests will succeed when cf_units supports NumPy 2... |
This PR address various issues:
In addition, several formating issues were addressed...