-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new addon r.area.createweight #597
Conversation
This add-on can be used to create a weighting layer for dasymetric mapping using a Random Forest model.
Correct some formatting errors (Flake8)
Hi all, Thanks |
Most likely your version of black is too old. My Ubuntu 20.10 ships with black 19.x and it is too old. To format GRASS code, I have created a virtual environment with black 21.x from pip. This version is good enough to pass CI checks. |
Hi @marisn and thanks for the tip. I installed black 21.x to be sure, but I realized that I misinterpret the check performed on Github. I thought the Black check do a reformatting while it is just a --check --diff without modification. I didn't pushed the modified version on commit 3084764. Now it is done on de43005. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the manual page and made some grammar suggestions; hopefully someone else can have a look at the code
Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
Thank you @veroandreo and @wenzeslaus for the review. I integrated all the requested changes. Let me know if an extra action is needed from my side. |
* create r.area.createweight * remove empty folder * Add files for new add-on r.area.createweight This add-on can be used to create a weighting layer for dasymetric mapping using a Random Forest model. * Update r.area.createweight.py Correct some formatting errors (Flake8) * fix Pep8 syntax * attempt to fix Black formating issue * Apply suggestions from code review Co-authored-by: Veronica Andreo <veroandreo@gmail.com> * Apply suggestions from code review * Apply suggestions from code review * Remove njob check as suggested * Apply Black formating * fix multi-line option description * fix 2 issues with multi-line in module description Co-authored-by: Tais Grippa <tgrippa@ulb.ac.be> Co-authored-by: Grippa Tais <tais.grippa@ulb.be> Co-authored-by: Veronica Andreo <veroandreo@gmail.com>
Hi developpers,
We are pleased to push a new add-on for GRASS GIS. It can be used to create a weighting layer for dasymetric mapping using a Random Forest model.
Looking forward for your feedback.