Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/cronjobs_osgeo_lxd: allow register all addons keywords in main Keywords Index #780

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Aug 20, 2022

Implement (closes) #776. Before apply this PR, you have to apply this GRASS GIS PR, please.

@tmszi tmszi added manual Documentation related issues enhancement New feature or request labels Aug 20, 2022
@tmszi tmszi requested a review from neteler August 20, 2022 18:13
@neteler
Copy link
Member

neteler commented Aug 20, 2022

Thanks for implementing it, @tmszi ! I will test asap.

@neteler
Copy link
Member

neteler commented Sep 8, 2022

I could finally test this, sorry for the delay.

Very nice, we are almost there! E.g.

https://grass.osgeo.org/grass83/manuals/keywords.html#Sentinel
--> i.sentinel.* is listed.

The only thing to change is the URL: /var/www/code_and_data/ leaks into it which comes from the usage of a related link on the build server, so:

https://grass.osgeo.org/var/www/code_and_data/grass83/manuals/addons/i.sentinel.coverage.html

should be

https://grass.osgeo.org/grass83/manuals/addons/i.sentinel.coverage.html

(likewise for all other addons).

@tmszi
Copy link
Member Author

tmszi commented Sep 9, 2022

I could finally test this, sorry for the delay.

Very nice, we are almost there! E.g.

https://grass.osgeo.org/grass83/manuals/keywords.html#Sentinel --> i.sentinel.* is listed.

The only thing to change is the URL: /var/www/code_and_data/ leaks into it which comes from the usage of a related link on the build server, so:

https://grass.osgeo.org/var/www/code_and_data/grass83/manuals/addons/i.sentinel.coverage.html

should be

https://grass.osgeo.org/grass83/manuals/addons/i.sentinel.coverage.html

(likewise for all other addons).

Thanks Markus. This commit OSGeo/grass@4fe3a0b solve it.

addons_man_page_relative_link

@neteler
Copy link
Member

neteler commented Sep 9, 2022

Thanks Markus. This commit OSGeo/grass@4fe3a0b solve it.

Excellent, I have just tested it on the server and it works.
@ all: Please have a look if all manual/addon links work.

GRASS GIS 8 manual:

@tmszi tmszi merged commit 3a70dfc into OSGeo:grass8 Sep 9, 2022
@neteler
Copy link
Member

neteler commented Sep 9, 2022

@tmszi seems a double // leaks in somewhere, only discovered that now.

@neteler
Copy link
Member

neteler commented Sep 9, 2022

@tmszi seems a double // leaks in somewhere, only discovered that now.

I cleaned up the local server patches, updated and recompiled.

This effect only happens with the "grass-stable" redirects:

https://grass.osgeo.org/grass-stable/manuals/addons/d.vect.colbp.html
--> https://grass.osgeo.org/grass82//manuals/addons/d.vect.colbp.html

Probably it is an issue of the Apache redirect (but I think to not have seen it before).

@tmszi
Copy link
Member Author

tmszi commented Sep 9, 2022

@tmszi seems a double // leaks in somewhere, only discovered that now.

I cleaned up the local server patches, updated and recompiled.

This effect only happens with the "grass-stable" redirects:

https://grass.osgeo.org/grass-stable/manuals/addons/d.vect.colbp.html --> https://grass.osgeo.org/grass82//manuals/addons/d.vect.colbp.html

Probably it is an issue of the Apache redirect (but I think to not have seen it before).

I found // in URL here https://grass.osgeo.org/grass82//manuals/index.html

@tmszi
Copy link
Member Author

tmszi commented Sep 9, 2022

Could @neteler share Apache config/part of config (if it possible), please?

@neteler
Copy link
Member

neteler commented Sep 9, 2022

Could @neteler share Apache config/part of config (if it possible), please?

Yes - I have sent it to you via personal email.

@tmszi
Copy link
Member Author

tmszi commented Sep 9, 2022

Could @neteler share Apache config/part of config (if it possible), please?

Yes - I have sent it to you via personal email.

Ok. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request manual Documentation related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants