g.citation: update regex to get date and author from manual #808
Conversation
|
OK to merge? Tests succeed as far as they can... |
I apologize, but since Wednesday evening I have a health problem that does not allow me to comfortably work on the computer. I should be fine within five days, maybe sooner. Please wait for my review. I'll look into it as soon as I can. |
src/general/g.citation/g.citation.py
Outdated
| # TODO: raise or fatal? should be in library or module? | ||
| raise RuntimeError("The text does not contain date entry") | ||
| raise RuntimeError("Could not parse date from maual") |
There was a problem hiding this comment.
No idea right now how shown to the user, but would prefer a complete sentence. :-)
There was a problem hiding this comment.
Writing error messages is hard. I'm not sure what should be there. I think I understand why you don't like the original one, but the new one does not feel right either. I find this article informative, but still hard to implement.
There was a problem hiding this comment.
Interesting and useful article. I tried to clarify why the error may have occurred...
|
@tmszi do you think this is ready to merge? |
|
During testing, I found that the module |
* add testsuite * capture author and date from manual * adress code review * adress code review * fix spelling * correct date extract doc/message * black * improve error message * implement suggestions from review
Replace #677 that was accidentally closed