-
-
Notifications
You must be signed in to change notification settings - Fork 302
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* CI: Update labeler’s labels * Update labeler.yml * Update labeler.yml Co-authored-by: Markus Neteler <neteler@osgeo.org> * labeler: Add missing module categories and map scripts * labeler: remove Markdown label as it is included in docs label --------- Co-authored-by: Markus Neteler <neteler@osgeo.org>
- Loading branch information
Showing
1 changed file
with
96 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7650a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@echoix If you look at the commit message, you'll see what I mean by the importance of rewording the merge commit.
f7650a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly would you like to point out? I see that the history that ended up in this commit is preserved even though it’s a squashed commit, the reference to the PR for later investigations is there, the title starts with a tag that is understood for release notes and all contributions that enhanced the original submission are correctly attributed
f7650a9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are four repetitive lines:
and "Update labeler.yml" is totally uninformative.
It is not the history behind how the final commit evolves that is important for the future of the project, it is what and perhaps why the final merge commit brings.
If you see the log of a branch, say the main, THAT is telling/preserving the history of the project. Looking from that (branch/project) perspective it is quite uninteresting how many times you "updated labeler.yml", "applied black", "reverted thisorthat" etc., only what that commit actually changed and perhaps why.
There is a document on commit messages which originate from pre-git versioning systems, but largely holds today. Also may I suggest browse around for "commit message good practice".