-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Typo in i.vi.html + C code formatting #1998
Comments
@YannChemin Since we are talking about best practices - not that this would be written anywhere, you just learn by doing - please also use your fork on GitHub rather than the OSGeo repo to create branches, i.e., use the same approach as the people from outside of the development team have to use, see CONTRIBUTING.md. As a part of the team, you have the power to create branches in the OSGeo/grass repo, but that's meant for some more long term branches, mostly so you can create new release branches if needed. (Contributions towards documenting this somewhere are of course welcome.) |
thanks,
at this point i just dont understand anything but i guess things have
changed from cvs and svn with git then github.
i will read and maybe understand it one day.
…On Thu, Dec 2, 2021, 3:40 AM Vaclav Petras ***@***.***> wrote:
@YannChemin <https://github.com/YannChemin> Since we are talking about
best practices - not that this would be written anywhere, you just learn by
doing - please also use your fork on GitHub rather than the OSGeo repo to
create branches, i.e., use the same approach as the people from outside of
the development team have to use, see CONTRIBUTING.md
<https://github.com/OSGeo/grass/blob/main/CONTRIBUTING.md>. As a part of
the team, you have the power to create branches in the OSGeo/grass repo,
but that's meant for some more long term branches, mostly so you can create
new release branches if needed. (Contributions towards documenting this
somewhere are of course welcome.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1998 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM224GUHT3ZQTC76BF6EHDUO3MCPANCNFSM5JFIIMJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
fixes OSGeo#1998 - typo introduced in 6fb6afd - C formatting
fixes OSGeo#1998 - typo introduced in 6fb6afd - C formatting
Typo introduced in 6fb6afd:
grass/imagery/i.vi/i.vi.html
Line 87 in 6fb6afd
-> "fl" ligature has been eaten and needs to be written with two chars.
Also add the full citation of Karnieli, 1997.
Please also fix the C formatting in imagery/i.vi/ci.c using
utils/grass_indent.sh
@YannChemin - a wish: kindly offer the time to others to review a PR.
The text was updated successfully, but these errors were encountered: