Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Typo in i.vi.html + C code formatting #1998

Closed
neteler opened this issue Dec 1, 2021 · 2 comments · Fixed by #2007
Closed

[Bug] Typo in i.vi.html + C code formatting #1998

neteler opened this issue Dec 1, 2021 · 2 comments · Fixed by #2007
Assignees
Labels
bug Something isn't working
Milestone

Comments

@neteler
Copy link
Member

neteler commented Dec 1, 2021

Typo introduced in 6fb6afd:

pigment in cyanobacteria contributes in producing a relatively higher re ̄ ectance

-> "fl" ligature has been eaten and needs to be written with two chars.

Also add the full citation of Karnieli, 1997.

Please also fix the C formatting in imagery/i.vi/ci.c using utils/grass_indent.sh

@YannChemin - a wish: kindly offer the time to others to review a PR.

@neteler neteler added the bug Something isn't working label Dec 1, 2021
@neteler neteler added this to the 8.0.1 milestone Dec 1, 2021
@wenzeslaus
Copy link
Member

@YannChemin Since we are talking about best practices - not that this would be written anywhere, you just learn by doing - please also use your fork on GitHub rather than the OSGeo repo to create branches, i.e., use the same approach as the people from outside of the development team have to use, see CONTRIBUTING.md. As a part of the team, you have the power to create branches in the OSGeo/grass repo, but that's meant for some more long term branches, mostly so you can create new release branches if needed. (Contributions towards documenting this somewhere are of course welcome.)

@YannChemin
Copy link
Contributor

YannChemin commented Dec 2, 2021 via email

neteler added a commit that referenced this issue Dec 8, 2021
fixes #1998

- typo introduced in 6fb6afd
- C formatting
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
fixes OSGeo#1998

- typo introduced in 6fb6afd
- C formatting
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
fixes OSGeo#1998

- typo introduced in 6fb6afd
- C formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants