Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] v.to.rast use=attr does not convert all points #2475

Closed
marisn opened this issue Jul 1, 2022 · 2 comments · Fixed by #2537
Closed

[Bug] v.to.rast use=attr does not convert all points #2475

marisn opened this issue Jul 1, 2022 · 2 comments · Fixed by #2537
Labels
bug Something isn't working vector Related to vector data processing
Milestone
8.2.1

Comments

@marisn
Copy link
Contributor

marisn commented Jul 1, 2022

For some reason v.to.rast fails to convert all vector points if as a value source is set attribute table. Although attribute column contains 2000 not null values, only 113 raster points are generated. If value source is set to val, all 2000 points are present in output raster.

A further investigation needs to be done to determine why cat values in do_line L40 coming back from Vect_read_line are botched.
@marisn marisn added bug Something isn't working vector Related to vector data processing labels Jul 1, 2022
@marisn
Copy link
Contributor Author

marisn commented Jul 3, 2022

For some reason every vector point had two cat values where second was sane but first was completely random indicating on an earlier failure. As I was not able to reproduce steps how garbage cat values were generated, closing as v.to.rast was just generating bad results based on bad data.
Note: if vector object has more than one cat in specified layer, only first cat is used to determine target value.

@marisn marisn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2022
marisn added a commit to marisn/grass that referenced this issue Aug 26, 2022
@marisn
v.random: do not transfer cat from area if attributes are coppied too
ab3ebfc 
Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes OSGeo#2475.
@marisn marisn mentioned this issue Aug 26, 2022
Merged
@marisn
Copy link
Contributor Author

marisn commented Aug 26, 2022

For the record – the bug was in v.random and will be fixed by merging PR #2537

marisn added a commit that referenced this issue Sep 25, 2022
@marisn
v.random: do not transfer cat from area if attributes are coppied too (…
82fb7b8 
…#2537)

Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes #2475.
neteler pushed a commit that referenced this issue Oct 17, 2022
@marisn @neteler
v.random: do not transfer cat from area if attributes are coppied too (…
3fbda3e 
…#2537)

Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes #2475.
@neteler neteler added this to the 8.2.1 milestone Oct 17, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
@marisn @ninsbl
v.random: do not transfer cat from area if attributes are coppied too (…
ba122c7 
…OSGeo#2537)

Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes OSGeo#2475.
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
@marisn @ninsbl
v.random: do not transfer cat from area if attributes are coppied too (…
085b43f 
…OSGeo#2537)

Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes OSGeo#2475.
neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023
@marisn @neteler
v.random: do not transfer cat from area if attributes are coppied too (…
e2b4699 
…OSGeo#2537)

Current code creates two cat entries for each point on the same level -
one from area point is in and one matching new entry in the database.
As entries in db have new cat values, old cat value points to a random
or non-existing entry in the db thus causing a mess.
Fixes OSGeo#2475.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working vector Related to vector data processing
Projects
None yet
Milestone
8.2.1
Development

Successfully merging a pull request may close this issue.

v.random: do not transfer cat from area if attributes are coppied too marisn/grass
2 participants
@neteler @marisn