Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] configure --with-wxwidgets doesn't do anything #2578

Closed
ojwb opened this issue Sep 15, 2022 · 2 comments
Closed

[Bug] configure --with-wxwidgets doesn't do anything #2578

ojwb opened this issue Sep 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ojwb
Copy link

ojwb commented Sep 15, 2022

Describe the bug

The --with-wxwidgets option sets the with_wxwidgets variable, but this is no longer used anywhere.

This option was entirely removed in 3e6f761 but then f1bb8d5 added PDAL support also partly restored the --with-wxwidgets option (my guess is due to a badly resolved merge conflict).

To Reproduce
Steps to reproduce the behavior:

  1. configure with --with-wxwidgets=/totally/bogus/path
  2. See that this bad value is silently accepted

Expected behavior
I would expect this option to have been removed and this option to be warned about as unrecognised:

configure: WARNING: unrecognized options: --with-wxwidgets

Screenshots
If applicable, add screenshots to help explain your problem.

System description (please complete the following information):

  • Operating System: Debian unstable
  • GRASS GIS version git master (6b61d10)

Additional context
Add any other context about the problem here.
@ojwb ojwb added the bug Something isn't working label Sep 15, 2022
sisco0 added a commit to sisco0/grass that referenced this issue Oct 5, 2022
@sisco0
fix: remove unused wxwidgets compilation configuration option
02c1c2f 
The configuration option wxwidget has been removed

Refs: OSGeo#2578
@sisco0 sisco0 mentioned this issue Oct 5, 2022
Merged
@sisco0
Copy link
Contributor

sisco0 commented Oct 5, 2022

@ojwb Could you kindly check that the referenced PR #2593 works as expected by your side?

nilason pushed a commit that referenced this issue Oct 9, 2022
@sisco0
configure: remove unused wxwidgets compilation configuration option (#…
3c260ef 
…2593)

The configuration option wxwidget has been removed

Refs: #2578
nilason pushed a commit that referenced this issue Oct 9, 2022
@sisco0 @nilason
configure: remove unused wxwidgets compilation configuration option (#…
7a5ad84 
…2593)

The configuration option wxwidget has been removed

Refs: #2578
@nilason
Copy link
Contributor

nilason commented Oct 9, 2022

Fixed with #2593

@nilason nilason closed this as completed Oct 9, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
@sisco0 @ninsbl
configure: remove unused wxwidgets compilation configuration option (O…
0bd6eed 
…SGeo#2593)

The configuration option wxwidget has been removed

Refs: OSGeo#2578
@tmszi tmszi mentioned this issue Oct 31, 2022
Closed
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
@sisco0 @ninsbl
configure: remove unused wxwidgets compilation configuration option (O…
76b5b1f 
…SGeo#2593)

The configuration option wxwidget has been removed

Refs: OSGeo#2578
marisn pushed a commit to marisn/grass that referenced this issue Jun 2, 2023
@sisco0 @marisn
configure: remove unused wxwidgets compilation configuration option (O…
bb29cef 
…SGeo#2593)

The configuration option wxwidget has been removed

Refs: OSGeo#2578
neteler pushed a commit to nilason/grass that referenced this issue Nov 7, 2023
@sisco0 @neteler
configure: remove unused wxwidgets compilation configuration option (O…
505b23b 
…SGeo#2593)

The configuration option wxwidget has been removed

Refs: OSGeo#2578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ojwb @nilason @sisco0