Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Packaging: include all version data in tarball #3430

Closed
nilason opened this issue Feb 16, 2024 · 0 comments
Closed

[Feat] Packaging: include all version data in tarball #3430

nilason opened this issue Feb 16, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nilason
Copy link
Contributor

nilason commented Feb 16, 2024

Is your feature request related to a problem? Please describe.

A number of Git connected data is needed for GRASS to identify itself in build/run time, e.g. GRASS_VERSION_GIT, GRASS_HEADERS_GIT_DATE and in addition release packages are accompanied by ´core_modules_with_last_commit` patches.

This has caused a number of problems, recently addressed with #3417.

Describe the solution you'd like

The data from Git are known at the time of packaging and may be included in the tarball, thus save us and others a lot of trouble.

The way to achieve this may be to create a simple textfile containing necessary information and include this file in release tarball. configure.ac need to be adopted to this and a Publishing workflow can be created (something similar to https://github.com/OSGeo/gdal-grass/blob/main/.github/workflows/publish.yml) which prepares the tarball and then publishes it.

@nilason nilason added the enhancement New feature or request label Feb 16, 2024
@nilason nilason added this to the 8.4.0 milestone Feb 16, 2024
@nilason nilason self-assigned this Feb 16, 2024
@echoix echoix closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants